Clean up TriggerScriptTest #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use waits (don't assume text and controls appear instantly). Re-enabled test marked as ignored because of Issue 25741 (it was fixed 3 years ago).
labkey-danield
requested review from
a team and
labkey-sweta
and removed request for
a team
labkey-sweta
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The TriggerScriptTest failed in develop and 24.3 because it wasn't catching the expected text. This changes the test to use waitFor to wait for expected texts and elements.
This also re-enabled a test that had been marked as ignore because of Issue 25741. The issue was fixed three years ago.
24.3 TeamCity run of test.
Related Pull Requests
Changes