Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nonces to script tags #1831

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Add nonces to script tags #1831

merged 6 commits into from
Feb 20, 2024

Conversation

labkey-adam
Copy link
Contributor

Rationale

CSPs like nonces. Also, path-first URL are preferred.

Copy link
Member

@labkey-tchad labkey-tchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One bad URL change.
Everything in data is used to populate wikis; I thought wikis didn't need to have the nonces explicitly defined?

src/org/labkey/test/tests/FileAttachmentColumnTest.java Outdated Show resolved Hide resolved
@labkey-adam
Copy link
Contributor Author

One bad URL change. Everything in data is used to populate wikis; I thought wikis didn't need to have the nonces explicitly defined?

You're correct... I'm not sure how I misread their usages. I think they're all corrected now.

@labkey-adam labkey-adam merged commit c9c0a95 into develop Feb 20, 2024
3 checks passed
@labkey-adam labkey-adam deleted the fb_nonces branch February 20, 2024 01:47
@labkey-adam labkey-adam mentioned this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants