wait for the search indexer more generally before cleaning up after tests #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This is a follow-up to discussion in https://github.com/LabKey/biologics/pull/2711.
To recap, it was suggested that a wait for the indexer before cleaning up after tests might be a reasonable way to more broadly prevent tests from generating failures if the search indexer is indexing something (as in this case, a sampleType) while test-cleanup is deleting it.
This adds a call to
SearchAdminAPIHelper.waitForIndexerBackground()inBaseWebDriverTest.waitForPendingRequests()with the intention of avoiding race-condition failures where the container delete gets there before the indexer is finishedRelated Pull Requests
https://github.com/LabKey/biologics/pull/2711
Changes
waitForPendingRequests()