Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip CSP check if running against a remote server #1763

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Skip CSP check if running against a remote server #1763

merged 1 commit into from
Dec 20, 2023

Conversation

labkey-tchad
Copy link
Member

Rationale

The CSP check is causing a bit of unnecessary noise.

  • If the target server is remote, the CSP should just no-op instead of failing
  • If the checker can't find the CSP log file, it should stop trying after the first failure

Related Pull Requests

Changes

  • Skip impossible CSP check for remote servers
  • Only fail once for missing CSP log file

@labkey-tchad labkey-tchad requested review from a team and labkey-danield and removed request for a team December 19, 2023 20:56
@labkey-tchad labkey-tchad merged commit f063aad into develop Dec 20, 2023
2 checks passed
@labkey-tchad labkey-tchad deleted the fb_skipCspCheckOnRemote branch December 20, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-danield labkey-danield labkey-danield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-tchad @labkey-danield