Remove dependency on repacked jetty #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-tchad
requested review from
labkey-jeckels,
a team and
labkey-danield
and removed request for
a team
labkey-jeckels
approved these changes
Dec 15, 2023
labkey-danield
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Selenium created a repacked version of jetty for reasons that are unclear to me. It hasn't been updated since 2019 and Selenium no longer uses or updates it and it has a transitive dependency that we are tying to eliminate (
javax.servlet-api).Tests only use this for URL encoding, so switching to the non-repacked version should work for our needs.
Related Pull Requests
Changes
org.seleniumhq.selenium:jetty-repackedtoorg.eclipse.jetty:jetty-util