Add test flag to check for CSP warnings #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-tchad
requested review from
a team and
labkey-danield
and removed request for
a team
labkey-danield
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Did you want to add @labkey-sweta and @labkey-chrisj to review as well?
| @@ -1141,6 +1143,8 @@ private void doPostamble() | |||
| if (isTestRunningOnTeamCity()) | |||
| checkActionCoverage(); | |||
|
|
|||
| CspLogUtil.checkNewCspWarnings(getArtifactCollector()); | |||
There was a problem hiding this comment.
Since CspLogUtil.checkNewCspWarnings can throw an assert or an exception shouldn't this line be in a try/catch? Otherwise this is saying that if there was some issue with the csp we cannot/will not check the links or any of the other actions that follow.
There was a problem hiding this comment.
This matches the behavior for all of the existing checks
This was referenced Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
A Tomcat Content Security Policy can be configured to report back to a server. LabKey now supports this reporting and logs warnings to
csp-report.log. Tests should be able to check this file for warnings, similar to how we check the server's error log.The new
webtest.cspCheckflag enables this check.Related Pull Requests
Changes