Assay Transform Script UX update to allow file drop and file path entry #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- and add option to also upload the transform script file to the new @scripts dir, update a few test cases to use this option
labkey-danield
approved these changes
Nov 22, 2023
Yes, multiple transform scripts can be added to the assay design. But it is still just one file upload at a time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
See rationale from related PRs. This PR updates ReactAssayDesignerPage to fix the existing helper for adding transform script via path and adds an option to also upload the transform script file to the new @scripts dir. A few test cases have been updated to use this new option.
Related Pull Requests
Changes