Skip to content

Commit

Permalink
Empty grid cell for an integer field should only show "required" mess…
Browse files Browse the repository at this point in the history
…age.

Mark upgrade tests as disabled so they don't show up in other git tests.
  • Loading branch information
labkey-danield committed Jan 23, 2025
1 parent a036559 commit b557037
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions src/org/labkey/test/tests/ServerUpgradeTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,14 @@
import org.labkey.test.BaseWebDriverTest;
import org.labkey.test.Locator;
import org.labkey.test.WebTestHelper;
import org.labkey.test.categories.Git;
import org.labkey.test.categories.Disabled;
import org.openqa.selenium.WebElement;

import java.util.Collections;
import java.util.List;

@Category({Git.class})
// Don't run as a git test, explicitly add this test to a suite file.
@Category({Disabled.class})
public class ServerUpgradeTest extends BaseWebDriverTest
{

Expand Down
2 changes: 1 addition & 1 deletion src/org/labkey/test/tests/component/EditableGridTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -1377,7 +1377,7 @@ public void testInputCellValidation()
mouseOver(testGrid.getCell(0, "Row")); // dismiss warning popup
testGrid.setCellValue(1, REQ_INT_FIELD_NAME + " *", " ");
checker().verifyEquals("Cell warning status not as expected at row " + 1 + " for col " + REQ_INT_FIELD_NAME, true, testGrid.hasCellWarning(1, REQ_INT_FIELD_NAME + " *"));
checker().verifyEquals("Cell warning msg not as expected at row " + 1 + " for col " + REQ_INT_FIELD_NAME, "Invalid integer. " + REQ_INT_FIELD_NAME + " is required.", testGrid.getCellPopoverText(1, REQ_INT_FIELD_NAME + " *"));
checker().verifyEquals("Cell warning msg not as expected at row " + 1 + " for col " + REQ_INT_FIELD_NAME, REQ_INT_FIELD_NAME + " is required.", testGrid.getCellPopoverText(1, REQ_INT_FIELD_NAME + " *"));

log("Correct values should remove cell warning, keep entering wrong values should update warning");
mouseOver(testGrid.getCell(0, "Row")); // dismiss warning popup
Expand Down

0 comments on commit b557037

Please sign in to comment.