Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve upgrade workflow for embedded Tomcat #752

Merged
merged 14 commits into from
Mar 12, 2024
Merged

Improve upgrade workflow for embedded Tomcat #752

merged 14 commits into from
Mar 12, 2024

Conversation

labkey-tchad
Copy link
Member

@labkey-tchad labkey-tchad commented Mar 4, 2024 •
edited
Loading

Rationale

#725

Related Pull Requests

Changes

  • Remove 'server' directory from embedded labkey
  • Add application.properties for distributions
  • Detect when to upgrade an existing embedded deployment

This was referenced Mar 4, 2024
Merged
Merged
@labkey-tchad labkey-tchad linked an issue Mar 4, 2024 that may be closed by this pull request
[LabKey CI] Improve upgrade workflow for embedded Tomcat #725
Closed
14 tasks
@labkey-tchad labkey-tchad mentioned this pull request Mar 4, 2024
Closed
14 tasks
@labkey-tchad labkey-tchad marked this pull request as ready for review March 6, 2024 01:14
labkey-jeckels
labkey-jeckels requested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good but a few requests and questions.

server/configs/webapps/embedded/README.txt Show resolved Hide resolved
server/embedded/src/org/labkey/embedded/EmbeddedExtractor.java Outdated Show resolved Hide resolved
server/embedded/src/org/labkey/embedded/EmbeddedExtractor.java Outdated Show resolved Hide resolved
server/configs/webapps/embedded/config/application.properties Show resolved Hide resolved
@labkey-tchad labkey-tchad merged commit adb39ba into release24.3-SNAPSHOT Mar 12, 2024
5 checks passed
@labkey-tchad labkey-tchad deleted the 24.3_fb_embedded_upgradeImprovements branch March 12, 2024 16:37
This was referenced Mar 12, 2024
Merged
Merged
@labkey-tchad labkey-tchad mentioned this pull request Mar 27, 2024
Merged
@labkey-tchad labkey-tchad mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-jeckels labkey-jeckels labkey-jeckels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LabKey CI] Improve upgrade workflow for embedded Tomcat
2 participants
@labkey-tchad @labkey-jeckels