Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration and tasks for capturing tomcat libs for RecompilingJspClassLoader #702

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

labkey-susanh
Copy link
Contributor

@labkey-susanh labkey-susanh commented Jan 31, 2024

Rationale

The RecompilingJspClassLoader currently depends on getting the tomcat libraries it needs from the local installation of tomcat. As we march toward using embedded Tomcat, we need a different way to make these jar files available for the classpath. This PR adds a task (and its cleaning partner) to copy the same dependencies used by Gradle to a build/jspRecompiling directory. The task depends on the apacheTomcatVersion property so should get refreshed as new versions are requested.

Related Pull Requests

Changes

  • add jspRecompileSetup and cleanJspRecompileSetup tasks to the :server project along with the requisite configuration

Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally - looks good

@labkey-susanh labkey-susanh merged commit fb540fc into develop Jan 31, 2024
1 of 4 checks passed
@labkey-susanh labkey-susanh deleted the fb_jspRecompilingSetup branch January 31, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants