Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configuration of second data source for embedded Tomcat #696

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix configuration of second data source for embedded Tomcat #696

merged 1 commit into from
Jan 30, 2024

Conversation

labkey-tchad
Copy link
Member

Rationale

The replacement strings in application.properties should match what's in labkey.xml so that we can switch to embedded more easily.

Related Pull Requests

Changes

  • Fix some replacement strings in application.properties

@labkey-tchad labkey-tchad requested review from a team and labkey-sweta and removed request for a team January 30, 2024 00:03
@labkey-tchad
Copy link
Member Author

Verifying on TeamCity: https://teamcity.labkey.org/buildConfiguration/LabKey_EmbeddedTomcat_Internal_InternalSuites_RedshiftPostgres/2878878

@labkey-tchad labkey-tchad merged commit 38bf5fc into develop Jan 30, 2024
5 checks passed
@labkey-tchad labkey-tchad deleted the fb_embedded_extraJdbcParamNames branch January 30, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-sweta labkey-sweta labkey-sweta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-tchad @labkey-sweta