Upgrade TinyMCE and Wiki #4969
Merged
Upgrade TinyMCE and Wiki #4969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-ians
force-pushed
the
fb_tinyUpgrade
branch
3 times, most recently
from
864acda to
cab9a46
Compare
labkey-ians
force-pushed
the
fb_tinyUpgrade
branch
from
78fe750 to
416f824
Compare
labkey-adam
requested changes
Nov 28, 2023
labkey-ians
force-pushed
the
fb_tinyUpgrade
branch
from
4468452 to
45cdf51
Compare
RosalineP
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
This is looking good! I did a light amout of manual testing with old wiki issues I remembered and the new editor handled it all nicely. The functionality parity (like not having a fullscreen mode anymore) makes sense. I had a few questions but nothing blocking.
labkey-adam
approved these changes
Nov 30, 2023
Always show warning when switching between source and visual tabs tweak toolbars and menus
Adjust warning message remove todos and commented code fix keyboard shortcut
labkey-ians
force-pushed
the
fb_tinyUpgrade
branch
from
50fb8ae to
8d8545b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Clean up a lot of CSP errors, and upgrade the TinyMCE editor that we've been using forever. Pseudo-spec: https://docs.google.com/document/d/1U0rXcOUUWnJVPFeFTHX0YMNzSej-pu2AKInPGPYoA9Q/edit
Related Pull Requests
Changes
Wikimodule to use new version