Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement to have permissions to all related issues from restricted issue detail view #1208

Open
wants to merge 3 commits into
base: release23.11-SNAPSHOT
Choose a base branch
from
Open

Remove requirement to have permissions to all related issues from restricted issue detail view #1208

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1f513b
Remove related issue requirement
brentlogan Dec 14, 2024
ecfb562
Merge branch 'refs/heads/release23.11-SNAPSHOT' into 23.11_fb_modifyP…
brentlogan Dec 28, 2024
158acb1
Merge branch 'refs/heads/release23.11-SNAPSHOT' into 23.11_fb_modifyP…
brentlogan Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions onprc_ehr/src/org/labkey/onprc_ehr/issues/RestrictedIssueProviderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,21 +95,6 @@ public boolean hasPermission(User user, @NotNull Issue issue, List<Issue> relate
return false;
}
}

// the user must also have access to all related issues
for (Issue related : relatedIssues)
{
Container relatedContainer = ContainerManager.getForId(related.getContainerId());
if (relatedContainer != null && isRestrictedIssueTracker(relatedContainer, related.getIssueDefName()))
{
Group relatedGroup = getRestrictedIssueListGroup(relatedContainer, related.getIssueDefName());
if (!checkAccess(user, related, relatedGroup))
{
errors.add(new SimpleValidationError(String.format("A related issue : %d is in a restricted issue list. You do not have access to that issue", related.getIssueId())));
return false;
}
}
}
return true;
}

Expand Down