Remove combineParentTypes #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnathe
approved these changes
Nov 1, 2024
labkey-alan
force-pushed
the
fb_remove_combineParentTypes
branch
from
aeeeea6 to
d1d5186
Compare
This was referenced Nov 5, 2024
labkey-alan
force-pushed
the
fb_remove_combineParentTypes
branch
from
d1d5186 to
0de34f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We have a combineParentTypes flag used by Biologics combine samples and sources as parent types when creating entities and editing their lineage. We want to remove this flag so SM and Biologics have the same behavior. See Issue 51486
Related Pull Requests
Changes