Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Menu: Flex layout #1469

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Product Menu: Flex layout #1469

merged 5 commits into from
Apr 11, 2024

Conversation

labkey-nicka
Copy link
Contributor

@labkey-nicka labkey-nicka commented Apr 9, 2024

Rationale

This updates the ProductMenu (often referred to as the "Mega Menu") to utilize flex layout for menu sections. This simplifies the layout logic that is necessary and makes it so we can include static menu sections (e.g. plates) underneath dynamic menu sections (e.g. samples).

Related Pull Requests

Changes

  • Update product menu DOM structure to better support flex layout container/item paradigm.
  • Use flex layout both horizontally (row-wise) across the product and vertically (column-wise) within each section column.
  • Scroll within dynamic menu sections leaving the section headers position constant.
  • Apply a "no-scroll" CSS class to the document body when product navigation is open. This prevents page scrolling.

@cnathe
Copy link
Contributor

cnathe commented Apr 9, 2024

@labkey-nicka I did some manual testing locally. The column / section scrolling behavior looks much better!

I found one small display issue when viewing the menu in a project without subfolders. The left side doesn't get any padding to match the right side:

Screenshot 2024-04-09 at 4 03 55 PM Screenshot 2024-04-09 at 4 04 19 PM

@labkey-nicka
Copy link
Contributor Author

@labkey-nicka I did some manual testing locally. The column / section scrolling behavior looks much better!

I found one small display issue when viewing the menu in a project without subfolders. The left side doesn't get any padding to match the right side:

Sure. This was case before my changes. I've adjusted so the first-child column always applies a padding-left.

@labkey-nicka labkey-nicka merged commit e4bd979 into develop Apr 11, 2024
1 check passed
@labkey-nicka labkey-nicka deleted the fb_mega_menu_plate branch April 11, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants