24.3 fb remove rename of labkeyServer.jar to app.jar #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WARNING: This PR appears to have the default title generated by GitHub. Please use something more descriptive. |
|
the GH actions didn't run on this as the workflows needed updates to run on release branches. Those changes were merged in PR78. However, I did validate this PR with a local build and test with last nights snapshot installers. |
labkey-stuartm
changed the title
labkey-willm
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
labkeyServer.jarfile was being renamed during the Dockerfile build - presumably due to previous installers appending a version number with each release. This PR removes the rename and preserves the jar file aslabkeyServer.jarRelated Pull Requests