-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LabKey Cloud] issue 49843: update ciphers #73
Merged
labkey-willm
merged 8 commits into
release24.3-SNAPSHOT
from
24.3_fb_24.3_update_ciphers
Mar 18, 2024
Merged
[LabKey Cloud] issue 49843: update ciphers #73
labkey-willm
merged 8 commits into
release24.3-SNAPSHOT
from
24.3_fb_24.3_update_ciphers
Mar 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-stuartm
approved these changes
Mar 13, 2024
labkey-willm
changed the title
issue 49843: update ciphers
[LabKey Cloud] issue 49843: update ciphers
Mar 13, 2024
labkey-jeckels
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll capture more detailed feedback in the issue, but I can't see a way to get an A rating from SSL Labs without getting a warning from Tomcat. I hate the spam in the log, but if I have to choose, I'd rather improve security than suppress the log message.
Co-authored-by: Josh Eckels <jeckels@labkey.com>
Co-authored-by: Josh Eckels <jeckels@labkey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
https://www.labkey.org/home/Developer/issues/Secure/issues-details.view?issueId=49843
default ciphers were out of date for tomcat 10. Updated per: https://tomcat.apache.org/tomcat-10.1-doc/config/http.html#SSL_Support_-_SSLHostConfig
also, latest docker-compose was resolving all the IDENT vars in the docker-compose.yml at once, so it thought there were conflicts. Had to uniquify.
Related Pull Requests
Changes