reconcile tomcat logging (requires v24.3) #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-willm
changed the title
labkey-adam
approved these changes
Mar 1, 2024
| <!-- category for Mule messages --> | ||
| <Logger name="org.mule.MuleManager" level="info"/> | ||
|
|
||
| <!-- | ||
| <Logger name="org.labkey.pipeline.mule.transformers" level="debug"/> | ||
| --> | ||
| --> | ||
|
|
||
| <!-- category for jasper messages --> | ||
| <Logger name="org.apache.jasper" level="warn"/> | ||
|
|
||
| <!-- application classes --> | ||
| <Logger name="org.fhcrc" level="info"/> |
There was a problem hiding this comment.
The two lines above (comment and org.fhcrc logger) were removed from the product version of this file since they should be covered by the new Root logger. There's no harm in keeping these lines; it's just an inconsistency.
|
Should this target the branch release24.3-Snapshot so that it will be a part of 24.3 release? |
labkey-stuartm
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
need to bring Dockerfile's log4j2.xml in line w/ latest updates in the built version.
Note: requires version 24.3 of LabKey.
Related Pull Requests
Changes
logging.configto application.properties. Note: file it points to must exist prior to app starting, and LOG4J_CONFIG_FILE env var takes precedence anyway.