Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump base image from 22.04 to 24.04 #131

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

labkey-willm
Copy link
Contributor

@labkey-willm labkey-willm commented Jan 10, 2025

Rationale

It's time to upgrade from the ubuntu 22.04 eclipse-temurin base image to 24.04.

We also want to repath the java ErrorFile argument to below $LABKEY_HOME/files, as this is commonly mounted to persistent storage outside the container. As heap dumps were already doing this, the heap dump directory has been slightly renamed to contain both heap dumps and error log files. Also added is a purge of old heap (and now error) directories, defaulting to 90+ days old.

As images built on Apple silicon (linux/arm64) are not usable on the linux/amd64 architecture commonly used in ECS, a BUILD_ARCHITECTURE build argument was added, defaulting to linux/amd64.

Related Pull Requests

Changes

  • eclipse-temurin base image default to noble (ubuntu 24.04)
  • set -XX:ErrorFile to below $LABKEY_HOME/files
  • BUILD_ARCHITECTURE build arg, default linux/amd64
  • PURGE_HEAP_AND_ERROR_LOGS_OLDER_THAN_DAYS env var, default 90 days

@labkey-willm labkey-willm changed the title bump base image from 20.04 to 24.04 bump base image from 22.04 to 24.04 Jan 10, 2025
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll let Stuart do the review of the parts that I don't know much about.

@labkey-willm labkey-willm merged commit b3044f1 into develop Jan 10, 2025
6 checks passed
@labkey-willm labkey-willm deleted the fb_ubuntu_20.04_to_24.04 branch January 10, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants