Skip to content

Commit 9c55905

Browse files
committed
ci: remove outdated comment on lint job
The logic got changed, but that comment remained. It has nothing to do with the actual logic anymore, so delete it. Also upgrade golangci-lint while we're at it.
1 parent 0219a16 commit 9c55905

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

.gitlab-ci.yml

+1-6
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,7 @@ lint:
3939
stage: test
4040
rules:
4141
- if: $CI_MERGE_REQUEST_ID
42-
# run golangci-lint on every commit. when we are in a merge request, only check
43-
# the changes inside that MR, otherwise check the whole codebase
44-
# (note: $CI_COMMIT_BEFORE_SHA is set to "" when we are not in a merge request,
45-
# but golangci-lint conventiently ignores the --new-from-rev flag when it's
46-
# empty, and so it checks the entire codebase like we want).
47-
image: golangci/golangci-lint:v1.26-alpine
42+
image: golangci/golangci-lint:v1.39-alpine
4843
script:
4944
- GOPATH=$(pwd)/.mygo go get github.com/vektra/mockery/.../
5045
- GOPATH=$(pwd)/.mygo PATH=$PATH:$(go env GOPATH)/bin go generate ./...

0 commit comments

Comments
 (0)