-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventPorts without EventOut not regarded #86
Comments
Thanks for that @kosti1992. I think this error is related to these issues in Inputs.xml: https://github.com/NeuroML/NeuroML2/blob/development/NeuroML2CoreTypes/Inputs.xml#L321, where an Do you have some example code that can help to see what the underlying issue is? |
Hello Padraig, A possible fix can be to use all out-eventports regardless if there is a event out directive or not, i.e. by not only iterating over the action blocks, but also inspect ports defined in the model. However, I tried to create a fix on model level (i.e. by modifying the explicitInput connection type , link ) but nothing Greetings, Konstantin |
I am not quite sure if it is a bug or intended behavior, but whenever we utilize an out EventPort in our model without the corresponding EventOut directive, this port seems not to be further regarded during the simulation. For example, if we define an explicit input (e.g. ), it is required to have an output port in the target model. If this model provides an out-port, but without a corresponding eventout directive, this port can not be further used. By debugging jLEMS I somehow tried to locate the problem: In core/run/WithBuilder, there is a method called postBuild() which is used to retrieve the source and target by the path. However, the component returned as source/target does not contain any output ports (if no out directive is stated), therefore the overall process stops with an nullpoint exception given the fact, that no output port can be found.
I am fully aware that we can avoid this problem by simply stating an event-out directive, but this can result in other problems, e.g. when components communicate between each other.
The text was updated successfully, but these errors were encountered: