Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Zarr V2 empty filter serialisation #147

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

LDeakin
Copy link
Owner

@LDeakin LDeakin commented Feb 17, 2025

It is no longer possible to create non-conformant Zarr V2 filter metadata by setting filters to Some(Vec![]). Zarr V2 arrays with filters: [] can still be read. zarr-python also shared this bug.

It is no longer possible to create non-conformant Zarr V2 filter metadata by setting filters to `Some(Vec![])`. Zarr V2 arrays with `filters: []` can still be read. `zarr-python` also shared this bug.
@LDeakin LDeakin merged commit 2d162fb into main Feb 17, 2025
20 checks passed
@LDeakin LDeakin deleted the v2_filter_serialisation branch February 17, 2025 20:41
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.19%. Comparing base (4775e84) to head (87d4783).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
zarrs_metadata/src/v2/array.rs 93.93% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   82.14%   82.19%   +0.05%     
==========================================
  Files         173      173              
  Lines       24582    24615      +33     
==========================================
+ Hits        20192    20232      +40     
+ Misses       4390     4383       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant