fix: use bytes codec with native endianness if unset for a Zarr V2 …

…array
LDeakin · Feb 5, 2025 · 9d05d14 · 9d05d14
1 parent fd10d56
commit 9d05d14
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/zarrs_metadata/CHANGELOG.md b/zarrs_metadata/CHANGELOG.md
@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+- Use `bytes` codec with native endianness if unset for a Zarr V2 array
+
 ## [0.3.2] - 2025-02-04
 
 ### Added

diff --git a/zarrs_metadata/src/v2_to_v3.rs b/zarrs_metadata/src/v2_to_v3.rs
@@ -66,6 +66,7 @@ pub enum ArrayMetadataV2ToV3ConversionError {
 ///
 /// # Errors
 /// Returns a [`ArrayMetadataV2ToV3ConversionError`] if the metadata is invalid or is not compatible with Zarr V3 metadata.
+#[allow(clippy::too_many_lines)]
 pub fn codec_metadata_v2_to_v3(
     order: ArrayMetadataV2Order,
     dimensionality: usize,
@@ -148,7 +149,9 @@ pub fn codec_metadata_v2_to_v3(
     if !has_array_to_bytes {
         let bytes_metadata = MetadataV3::new_with_serializable_configuration(
             crate::v3::array::codec::bytes::IDENTIFIER,
-            &BytesCodecConfigurationV1 { endian: endianness },
+            &BytesCodecConfigurationV1 {
+                endian: Some(endianness.unwrap_or(Endianness::native())),
+            },
         )?;
         codecs.push(bytes_metadata);
     }