Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added project live codepen Editor #1056

Closed
wants to merge 4 commits into from
Closed

Conversation

Arpcoder
Copy link

This closes #1017

@github-actions github-actions bot requested a review from Kushal997-das May 20, 2024 04:52
@Arpcoder
Copy link
Author

Please review this @Kushal997-das

@ghsharma
Copy link

@Arpcoder , I’ve reviewed your code and noticed a few areas that need improvement. Here are the details:

Specific issues and suggestions :

  1. Dead code files shall be removed.
  2. Have a clear and organized repository structure.
  3. Web development project should be deployed and the link should be provided in the readme file for inspection.
  4. Also add images of the project in the readme file.

@Arpcoder
Copy link
Author

Arpcoder commented May 20, 2024

@Arpcoder , I’ve reviewed your code and noticed a few areas that need improvement. Here are the details:

Specific issues and suggestions :

  1. Dead code files shall be removed.
  2. Have a clear and organized repository structure.
  3. Web development project should be deployed and the link should be provided in the readme file for inspection.
  4. Also add images of the project in the readme file.

Which level label you will give to this issue..level3?

@Kushal997-das
Copy link
Owner

@Arpcoder First fix the things what ghsharma said , before bothering about level.

@Kushal997-das Kushal997-das added the Changes-required Little bit changes required . label May 21, 2024
@Arpcoder
Copy link
Author

@Arpcoder First fix the things what ghsharma said , before bothering about level.

Done

Copy link
Owner

@Kushal997-das Kushal997-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the output is not showing properly. Try to fix that out.

see the output

@Kushal997-das Kushal997-das added the gssoc This level is for GSSOC label May 25, 2024
@Arpcoder
Copy link
Author

Arpcoder commented May 26, 2024

See the output is not showing properly. Try to fix that out.

see the output

Its already fixed.. If you refresh it, it will work properly... But leave now, I wanted level3 for this

@Arpcoder Arpcoder closed this May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes-required Little bit changes required . gssoc This level is for GSSOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding live codepen Editor project
3 participants