Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize get_file_hash Function and Improve Large File Handling Fixes #20 #60

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

ShirshenduR
Copy link
Contributor

@ShirshenduR ShirshenduR commented Oct 3, 2024

Description

This PR optimizes the get_file_hash function in utils.py to handle large files more efficiently. It increases the buffer size.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Tests update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented where necessary
  • No new warnings
  • All unit tests pass
  • Clean commit history
  • No merge conflicts

Screenshots (if applicable)

N/A

@ShirshenduR ShirshenduR changed the title Optimize get_file_hash Function and Improve Large File Handling Optimize get_file_hash Function and Improve Large File Handling Fixes #20 #34 Oct 3, 2024
@Kota-Karthik
Copy link
Owner

@ShirshenduR
workflow is failing
make necessary changes to fix it!

@ShirshenduR
Copy link
Contributor Author

@ShirshenduR workflow is failing make necessary changes to fix it!

I have changed the algorithm to blake2b it's testing for md5

@Kota-Karthik
Copy link
Owner

@ShirshenduR
make necessary changes wherever necessary to fix the workflow

optimized utils.py as told

changed utils.py to fix the workflow
@techy4shri
Copy link
Collaborator

Only 1 issue per PR! Do not raise a PR for multiple issues please!

@ShirshenduR ShirshenduR changed the title Optimize get_file_hash Function and Improve Large File Handling Fixes #20 #34 Optimize get_file_hash Function and Improve Large File Handling Fixes #20 Oct 4, 2024
@ShirshenduR
Copy link
Contributor Author

@Kota-Karthik please check now

@Kota-Karthik
Copy link
Owner

@ShirshenduR LGTM!

@Kota-Karthik Kota-Karthik merged commit cd38811 into Kota-Karthik:main Oct 4, 2024
2 checks passed
@ShirshenduR ShirshenduR deleted the utilsupdate branch October 6, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize get_file_hash Function for Large Files
3 participants