Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance AllFileMetadata: Add Logging, Error Handling, Type Annotations, and Documentation #117

Closed
wants to merge 1 commit into from

Conversation

Sushil2k4
Copy link

Description

-Added logging instead of print for better log management.

-Introduced error handling to log when a file is not found.

-Implemented type annotations for better readability and function understanding.

-Added detailed docstrings for improved code clarity and documentation.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • I have checked that my code does not cause any merge conflicts

@Kota-Karthik
Copy link
Owner

@Sushil2k4
please fix code which is breaking workflows
strictly follow the PR template
After you fix them i will review your PR
You can go through CONTRIBUTING.MD

Copy link
Collaborator

@techy4shri techy4shri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No mention of issue assigned to you, no proper commenting in your code, and I do not see you ever asking to be assinged to any issue. Due to violation of Contribution Guidelines, this PR is being closed and shall remain so. This is the first warning, treat it with utmost importance as any further violation will result in severe consequences.

@techy4shri techy4shri closed this Oct 16, 2024
@techy4shri techy4shri added REJECTED Pull request rejected invalid This doesn't seem right labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right REJECTED Pull request rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants