-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewer design alignment with semantic kompakkt #53
Comments
|
Alright, then the features for kompakkt can stay the same. Except for eventually removing the language feature. |
Thanks @HeyItsBATMAN and @Grizzly127, yes, language should be in a plugin for SK, since we don't yet have option to switch to German (which would be relevant to us), we should not include it for now. |
@Grizzly127 Sidebar design looks good, i just made some recommendations in Figma mostly connected to text changes. |
I implemented the text changes: The darkmode sidebar has slightly grey boxes to divide the parts better, instead of a line. It looked better than the line, I think. |
@Grizzly127 OK, I see - it was less noticeable in the dark mode and now I am not sure, we don't use these boxes within boxes anywhere else and it introduces a lot of extra padding - the sidebar is already narrow and within this sidebar we're adding another layer of padding that makes everything narrower. But mostly, if you look around the entire UI to date (in the Figma file) - we use grey input boxes within dialogs (eg see login or Register) and we sometimes use dividing lines, or something like lines, in places like the Upload wizard, but also in the display of metadata on the side of the viewer window, etc. So i think we should stick more to the existing UI, otherwise we'll have to revise a lot more sections to then use these rounded boxes. And in the case of the sidebar here, I don't think we even need dividing lines because you introduced the little section headings with the arrow symbol we also use in the metadata wizard. I would suggest you mock this up as a single block / sidebar without dividing lines and only using typography and padding to differentiate the sections. |
Here is the design without the boxes and without double background settings: |
Thanks @Grizzly127 I think this looks quite clear. Only small suggestion to keep things more consistent would be to make the input fields (x, y, z axis) in dark mode also a shade of grey different from the background (like they are in light mode). |
|
Options in the viewer for the object page
in kompakkt this options are available:
![Bildschirmfoto 2024-07-24 um 12 40 15](https://private-user-images.githubusercontent.com/44752496/351682356-d32afba5-91e7-4bbf-8ea8-e5c8f4b6b8e5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMDMwODMsIm5iZiI6MTczOTIwMjc4MywicGF0aCI6Ii80NDc1MjQ5Ni8zNTE2ODIzNTYtZDMyYWZiYTUtOTFlNy00YmJmLThlYTgtZTVjOGY0YjZiOGU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDE1NTMwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWEwNTYxNmU3YWQ5ZmRhY2E1ZGM3NTIxZTI2ZTg5YmQ2MzU4ZjcwMzI2NTJhZjE0ZDg0OGYwYTdhYmU4NGY0ZjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.DywYDtyHTtEK4mCBDoXqHTuAzilt8TJXxFZne9Shm3Q)
in semantic kompakkt this options are available:
![Bildschirmfoto 2024-07-24 um 12 39 36](https://private-user-images.githubusercontent.com/44752496/351682635-ce4b0817-70d7-46ed-bb11-5a3944a88f2f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMDMwODMsIm5iZiI6MTczOTIwMjc4MywicGF0aCI6Ii80NDc1MjQ5Ni8zNTE2ODI2MzUtY2U0YjA4MTctNzBkNy00NmVkLWJiMTEtNWEzOTQ0YTg4ZjJmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDE1NTMwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNjNDQ0MmZjOWI3YmEzN2RmZGU5NDk0MTY0MjNkMTY0Y2VlYjA5NjRkM2QyOTQ2MGEyYzNhNGJkMTQ0ZmNjOGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.8bF4fxthvtL4N-vrN7jiuKspc3wbd74EZRBK9K-WicM)
Which options are still relevant? Which ones should be used here?
@lozanaross @HeyItsBATMAN
The text was updated successfully, but these errors were encountered: