Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add White Label Girier JR-ZPM03 Smart Plug (_TZ3000_okaz9tjs) to TS011F_plug_3 #8560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add White Label Girier JR-ZPM03 Smart Plug (_TZ3000_okaz9tjs) to TS011F_plug_3 #8560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/devices/tuya.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5593,6 +5593,7 @@ const definitions: DefinitionWithExtend[] = [
{vendor: 'AVATTO', model: 'MIUCOT10Z'},
{vendor: 'Neo', model: 'NAS-WR01B'},
{vendor: 'Neo', model: 'PLUG-001SPB2'},
{vendor: 'Girier', model: 'JR-ZPM03', fingerprint: [{manufacturerName: '_TZ3000_okaz9tjs', manufacturerID: 4660}]},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use tuya.whitelabel() like below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this code work? because it shares the same manufacturerName as Tuya BSD29_1.

tuya.whitelabel('Girier', 'JR-ZPM03', 'Smart plug (with power monitoring by polling)', ['_TZ3000_okaz9tjs']),
tuya.whitelabel('Tuya', 'BSD29_1', 'Smart plug (with power monitoring by polling)', ['_TZ3000_okaz9tjs']),

if so, I'll commit the change.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No because the manufacturer name is exactly the same (_TZ3000_okaz9tjs)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any suggestion to differentiate 2 devices that share the same manufacturerName? maybe from manufacturerID?

maybe by passing fingerprint to whitelabel function (might need to update the whitelabel function.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the manufacturer ID will also be the same, I don't think there is a way to distinguish them.

tuya.whitelabel('Tuya', 'BSD29_1', 'Smart plug (with power monitoring by polling)', ['_TZ3000_okaz9tjs']),
],
ota: true,
Expand Down
Loading