Create and use wire pilot preset + refactoring #6597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esciara
force-pushed
the
create-and-use-wire-pilot-preset
branch
from
6071af1 to
7d8e860
Compare
|
I could not test the Legrand device, so either @FabianMangold @EXP-Carthage could help (I could not mention the others who also wrote/modified part of the code), or we can remove the related commit for the time being. |
|
Thanks! |
|
Ok for Legrand devices |
Thanks for confirming it works! |
|
Just wanted to add that now with this change, pilot wire mode is available by default on the dashboard 🎉! 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue Koenkk/zigbee2mqtt#19943
I separated changes in relevant commits:
Sister PR Koenkk/zigbee-herdsman#812