[PHP] Update phpstan libs (parti-renaissance#7192)

Author: ottaviano

composer.json

@@ -154,7 +154,10 @@
         "friendsofphp/php-cs-fixer": "^3.0",
         "league/flysystem-memory": "^1.0",
         "pedrotroller/php-cs-custom-fixer": "^2.25",
-        "phpstan/phpstan": "^0.12.66",
+        "phpstan/extension-installer": "^1.1",
+        "phpstan/phpstan": "^1.5",
+        "phpstan/phpstan-doctrine": "^1.3",
+        "phpstan/phpstan-symfony": "^1.1",
         "phpunit/phpunit": "^9.5",
         "symfony/css-selector": "^4.4",
         "symfony/debug-bundle": "^4.4",

composer.lock

@@ -5,3 +5,5 @@ parameters:
         - src
         - config
         - migrations
+    symfony:
+        containerXmlPath: var/cache/dev/srcApp_KernelDevDebugContainer.xml

phpstan.neon.dist

@@ -15,6 +15,7 @@
 use Sonata\DoctrineORMAdminBundle\Filter\CallbackFilter;
 use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
 
+/** @phpstan-ignore-next-line */
 class AdherentRoleFilter extends CallbackFilter
 {
     public function getDefaultOptions()

src/Admin/Filter/AdherentRoleFilter.php

@@ -6,6 +6,7 @@
 use Sonata\AdminBundle\Form\Type\ModelAutocompleteType;
 use Sonata\DoctrineORMAdminBundle\Filter\CallbackFilter;
 
+/** @phpstan-ignore-next-line */
 class ReferentTagAutocompleteFilter extends CallbackFilter
 {
     public function getDefaultOptions()

src/Admin/Filter/ReferentTagAutocompleteFilter.php

@@ -9,6 +9,7 @@
 use Sonata\DoctrineORMAdminBundle\Datagrid\ProxyQuery;
 use Sonata\DoctrineORMAdminBundle\Filter\CallbackFilter;
 
+/** @phpstan-ignore-next-line */
 class ZoneAutocompleteFilter extends CallbackFilter
 {
     public function getDefaultOptions(): array

src/Admin/Filter/ZoneAutocompleteFilter.php

@@ -171,7 +171,7 @@ private function importReferentManagedAreas(InputInterface $input, OutputInterfa
                 throw new \RuntimeException(sprintf('No Adherent found with uuid "%s". (line %d)', $uuid, $index + 2));
             }
 
-            if (empty($tags)) {
+            if (!\count($tags)) {
                 throw new \RuntimeException(sprintf('No tag found for Adherent "%s %s". (line %d)', $firstName, $lastName, $index + 2));
             }
 

src/Command/ReferentTagImportCommand.php

@@ -322,7 +322,6 @@ public function candidacyListAction(Committee $committee, CommitteeCandidacyRepo
         return $this->render('committee/candidacy/candidacy_list.html.twig', [
             'candidacies' => $repository->findAllConfirmedForElection($election),
             'election' => $election,
-            'membership' => $membership ?? null,
             'committee' => $committee,
             'designation' => $election->getDesignation(),
         ]);

src/Controller/EnMarche/CommitteeDesignation/CandidatureController.php

@@ -6,7 +6,6 @@
 use App\AdherentMessage\DynamicSegmentInterface;
 use App\Entity\Adherent;
 use App\Entity\AdherentMessage\Filter\AudienceFilter;
-use App\Entity\AdherentMessage\Filter\SegmentFilterInterface;
 use App\Entity\AuthorInterface;
 use App\Entity\DynamicSegmentTrait;
 use App\Entity\EntityIdentityTrait;
@@ -90,7 +89,7 @@ public function __construct(UuidInterface $uuid = null)
         $this->uuid = $uuid ?? Uuid::uuid4();
     }
 
-    public function getFilter(): ?SegmentFilterInterface
+    public function getFilter(): ?AudienceFilter
     {
         return $this->filter;
     }

src/Entity/AdherentMessage/Segment/AudienceSegment.php

@@ -143,7 +143,7 @@ public function getDataAnswers(): Collection
     }
 
     /**
-     * @return false|Collection|DataAnswer[]
+     * @return false|DataAnswer
      */
     public function getDataAnswersFor(SurveyQuestion $surveyQuestion, DataSurvey $dataSurvey)
     {

src/Entity/Jecoute/SurveyQuestion.php

@@ -11,4 +11,6 @@ interface CandidacyInvitationInterface
     public function setCandidacy(CandidacyInterface $candidacy): void;
 
     public function isPending(): bool;
+
+    public function getMembership(): ?object;
 }

src/Entity/VotingPlatform/Designation/CandidacyInvitationInterface.php

@@ -6,6 +6,7 @@
 use Sonata\AdminBundle\Form\Type\ModelAutocompleteType;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
+/** @phpstan-ignore-next-line */
 class AvailableDistrictAutocompleteType extends ModelAutocompleteType
 {
     public function configureOptions(OptionsResolver $resolver)

src/Form/Admin/AvailableDistrictAutocompleteType.php

@@ -56,7 +56,7 @@ public function buildFromMailchimpCampaign(MailchimpCampaign $campaign): array
             'list_id' => $this->getListId($message),
             'segment_opts' => array_merge($savedSegment, [
                 'match' => 'all',
-                'conditions' => $conditions ?? [],
+                'conditions' => $conditions,
             ]),
         ];
     }
@@ -84,7 +84,7 @@ public function buildFromDynamicSegment(DynamicSegmentInterface $dynamicSegment)
 
         return [
             'match' => 'all',
-            'conditions' => $conditions ?? [],
+            'conditions' => $conditions,
         ];
     }
 

src/Mailchimp/Campaign/SegmentConditionsBuilder.php

@@ -43,7 +43,9 @@ public function normalize($object, $format = null, array $context = [])
                     'gender' => $object->getPapCampaignHistory()->getGender(),
                     'age_range' => $object->getPapCampaignHistory()->getAgeRange(),
                 ];
+                /** @phpstan-ignore-next-line */
                 $dataSurvey['begin_at'] = $dataSurvey['pap_campaign_history']['begin_at'] ?? null;
+                /** @phpstan-ignore-next-line */
                 $dataSurvey['finish_at'] = $dataSurvey['pap_campaign_history']['finish_at'] ?? null;
             } elseif ($object->isOfPhoningCampaignHistory()) {
                 $dataSurvey['type'] = 'Phoning';
@@ -55,7 +57,9 @@ public function normalize($object, $format = null, array $context = [])
                         'age_range' => null,
                     ]
                     : null;
+                /** @phpstan-ignore-next-line */
                 $dataSurvey['begin_at'] = $dataSurvey['phoning_campaign_history']['begin_at'] ?? null;
+                /** @phpstan-ignore-next-line */
                 $dataSurvey['finish_at'] = $dataSurvey['phoning_campaign_history']['finish_at'] ?? null;
             } elseif ($object->isOfJemarcheDataSurvey()) {
                 $dataSurvey['type'] = 'Libre';