Fix integration with web components not working properly #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KittyGiraudel
force-pushed
the
web-components
branch
3 times, most recently
from
70347ff to
2ff9c65
Compare
4 tasks
gavmck
approved these changes
May 16, 2024
KittyGiraudel
force-pushed
the
web-components
branch
2 times, most recently
from
98d00de to
6ec9667
Compare
KittyGiraudel
force-pushed
the
web-components
branch
2 times, most recently
from
6234668 to
930d762
Compare
KittyGiraudel
force-pushed
the
web-components
branch
from
e549dbf to
1d82a6f
Compare
KittyGiraudel
force-pushed
the
web-components
branch
from
1d82a6f to
287962f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #582. This PR contains essentially 2 fixes:
The escape hatch for nested dialogs usedExtracted in Account for Shadow DOM when dealing with nested dialogs #706.document.activeElementandElement.prototype.closest()to detect whether the keypress should be ignore entirely. This did not play well with web components, and is fixed with the existinggetActiveElementutility, and a newclosestutility.event.composedPath(), but also readsevent.targetin case the composed path target is a slot. Thank god for our existing tests, otherwise I would have 100% broken that case.Honestly, web components has to be the worst thing that ever happened to HTML. What a goddamn mess, it‘s insane.