Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved effect on button and icons in the Footer #105

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Anjuli08
Copy link

@Anjuli08 Anjuli08 commented Oct 7, 2022

πŸ› οΈ Fixes Issue : #99

πŸ‘¨β€πŸ’» Changes proposed:

I have changed the color of social media icons both before and after hovering so they become visible.
I improved the subscribe button and changed its hovering color also.

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.
  • I am a participant of Hacktoberfest 2022.

πŸ“„ Note to reviewers

πŸ“· Screenshots

Screenshot (78)_LI

Screenshot (79)_LI

@netlify
Copy link

netlify bot commented Oct 7, 2022

βœ… Deploy Preview for leatherhoard ready!

Name Link
πŸ”¨ Latest commit 2a9e8e1
πŸ” Latest deploy log https://app.netlify.com/sites/leatherhoard/deploys/6353dbebd152ce00084fde23
😎 Deploy Preview https://deploy-preview-105--leatherhoard.netlify.app/
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Anjuli08
Copy link
Author

Anjuli08 commented Oct 8, 2022

please review this!

@KiranAminPanjwani
Copy link
Owner

Please don't make changes to the "Subscribe" button.

Copy link
Author

@Anjuli08 Anjuli08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edited changes

@KiranAminPanjwani
Copy link
Owner

edited changes

Please create a new pull request if you want to add your contribution under the label "Hacktoberfest 2023"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants