We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/KinkyMakers/OSSM-hardware/blob/master/Software/src/ossm/OSSM.StrokeEngine.cpp#L39
Stroker.setSpeed(ossm->setting.speed * 3, true);
in setSpeed, "speed" arg it must be "Strokes per Minute" https://github.com/KinkyMakers/OSSM-hardware/blob/master/Software/lib/StrokeEngine/src/StrokeEngine.h#L124C20-L124C38
But actually, is it a percent of speedKnob https://github.com/KinkyMakers/OSSM-hardware/blob/master/Software/src/ossm/OSSM.PlayControls.cpp#L74
This reduces the speed adjustment range to less than 20 percent of the remote command.
The text was updated successfully, but these errors were encountered:
Appears to have been introduced during the global rework #82
Sorry, something went wrong.
I'm going to try this fix tonight (no homing management)
// Stroker.setSpeed(ossm->setting.speed * 3, true); // Convert speedKnob percent consigne to stroke/min with settings from config float speedMmPerSecond = (Config::Driver::maxSpeedMmPerSecond * ossm->setting.speed) / 100.0; float strokePerSecond = speedMmPerSecond / Config::Driver::maxStrokeSteps; float strokePerMin = strokePerSecond * 60.0; Stroker.setSpeed(strokePerMin, true);
// Stroker.setSpeed(ossm->setting.speed * 3, true);
// Convert speedKnob percent consigne to stroke/min with settings from config
float speedMmPerSecond = (Config::Driver::maxSpeedMmPerSecond * ossm->setting.speed) / 100.0;
float strokePerSecond = speedMmPerSecond / Config::Driver::maxStrokeSteps;
float strokePerMin = strokePerSecond * 60.0;
Stroker.setSpeed(strokePerMin, true);
PR available: StrokeEngine: fix: drive StrokeEngine by speed #134
No branches or pull requests
https://github.com/KinkyMakers/OSSM-hardware/blob/master/Software/src/ossm/OSSM.StrokeEngine.cpp#L39
Stroker.setSpeed(ossm->setting.speed * 3, true);
in setSpeed, "speed" arg it must be "Strokes per Minute"
https://github.com/KinkyMakers/OSSM-hardware/blob/master/Software/lib/StrokeEngine/src/StrokeEngine.h#L124C20-L124C38
But actually, is it a percent of speedKnob
https://github.com/KinkyMakers/OSSM-hardware/blob/master/Software/src/ossm/OSSM.PlayControls.cpp#L74
This reduces the speed adjustment range to less than 20 percent of the remote command.
The text was updated successfully, but these errors were encountered: