-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate eslint to flat config #1926
Conversation
oh i never noticed, cause my code editor already is linting it on the fly |
I noticed there is a we can add prettier as lint rules too |
i guess when using stylistic it is not a good thing to add prettier as well. they are more or less there for the same purpose. |
Oh right, fair enough, leave it just as it is now |
can you check the ci and ping me, if you think the pr is ready? PS: nice to see/have a real life example with angular + stylistic. In other projects i hate to touch those things... |
@KillerCodeMonkey it's ok now, seems like my global npm proxy caused the error |
@BBboy01 thanks 👍 |
https://ngxtension.netlify.app/utilities/migrations/inject-migration/ if you like, we can easily use ngxtenstion provided script to migrate angular decorators to signals |
currently for inputs input signals are used. i am waiting til "model" signals are stable and replace some input with model signals. for outputs some more refactorings need be done, cause we are adding and triggering some outputs only if there are observers. So i need to check, if we need this logic at all and if, how we can adapt it with signals. |
use
npx eslint --inspect-config
browse all configured rulesngx-quill/.eslintrc.json
Lines 3 to 5 in db73b0c
previous ignore pattern ignored all ts files, eslint seems lint nothing
eslint-plugin-prefer-arrow
andeslint-plugin-import
@angular-eslint/*
withangular-eslint
'@typescript-eslint/no-explicit-any': 'off'
as rule