Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate eslint to flat config #1926

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

BBboy01
Copy link
Contributor

@BBboy01 BBboy01 commented Aug 28, 2024

use npx eslint --inspect-config browse all configured rules

"ignorePatterns": [
"projects/**/*"
],

previous ignore pattern ignored all ts files, eslint seems lint nothing

  • remove unused plugins eslint-plugin-prefer-arrow and eslint-plugin-import
  • replace @angular-eslint/* with angular-eslint
  • '@typescript-eslint/no-explicit-any': 'off' as rule

@KillerCodeMonkey
Copy link
Owner

oh i never noticed, cause my code editor already is linting it on the fly

@BBboy01
Copy link
Contributor Author

BBboy01 commented Aug 28, 2024

CleanShot 2024-08-28 at 14 21 41@2x

we dont need @eslint/js, it just provides languageOptions for js files, but we dont have a single js files and // @ts-check is much better

@BBboy01
Copy link
Contributor Author

BBboy01 commented Aug 28, 2024

I noticed there is a .prettirerc file but no prettier as dependency, I'm not sure are you using prettier for code formatting

we can add prettier as lint rules too

@KillerCodeMonkey
Copy link
Owner

I noticed there is a .prettirerc file but no prettier as dependency, I'm not sure are you using prettier for code formatting

we can add prettier as lint rules too

i guess when using stylistic it is not a good thing to add prettier as well. they are more or less there for the same purpose.

@BBboy01
Copy link
Contributor Author

BBboy01 commented Aug 28, 2024

i guess when using stylistic it is not a good thing to add prettier as well. they are more or less there for the same purpose.

Oh right, fair enough, leave it just as it is now

@KillerCodeMonkey
Copy link
Owner

can you check the ci and ping me, if you think the pr is ready?

PS: nice to see/have a real life example with angular + stylistic. In other projects i hate to touch those things...

@BBboy01
Copy link
Contributor Author

BBboy01 commented Aug 28, 2024

@KillerCodeMonkey it's ok now, seems like my global npm proxy caused the error

@KillerCodeMonkey KillerCodeMonkey merged commit 35be3ad into KillerCodeMonkey:master Aug 28, 2024
1 check passed
@KillerCodeMonkey
Copy link
Owner

@BBboy01 thanks 👍

@BBboy01
Copy link
Contributor Author

BBboy01 commented Aug 28, 2024

https://ngxtension.netlify.app/utilities/migrations/inject-migration/

if you like, we can easily use ngxtenstion provided script to migrate angular decorators to signals

@KillerCodeMonkey
Copy link
Owner

currently for inputs input signals are used. i am waiting til "model" signals are stable and replace some input with model signals.

for outputs some more refactorings need be done, cause we are adding and triggering some outputs only if there are observers. So i need to check, if we need this logic at all and if, how we can adapt it with signals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants