Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C++14 compatibility option (for legacy environment support) #3880

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nihui
Copy link
Contributor

@nihui nihui commented Feb 19, 2025

Hello glslang maintainers

I've created an optional compatibility branch (cpp14) to support environments requiring C++14 standard compliance.
This implementation serves projects like ncnn (Tencent/ncnn#5910) that require C++14 compatibility while needing access to newer glslang features

Key Changes

  • downgrade cmake version required
  • revert usage of <optional> <filesystem> <variant> <span>

Validation

  • ctest passed
  • verified compilers:
    android ndk r16b
    msvc 2015+
    apple clang for tvos-11.0
    hmos sdk 4.1

Feel free to close this PR after review - I'll maintain the branch separately.
Appreciate your consideration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant