Merge pull request #42 from Keyfactor/pswd-logging

Pswd logging
Keyfactor · Jan 3, 2024 · f70ebd6 · f70ebd6
2 parents 7126605 + 9b64022
commit f70ebd6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+v2.4.1
+- Fix logging issue for RFKDB
+
 v2.4.0
 - Add new optional custom parameter, IgnorePrivateKeyOnInventory, for RFPEM, which will allow inventorying RFPEM certificate stores where the store password is unknown.  This will make the store INVENTORY ONLY.  Once the store password is added, this option can be de-selected (set to False), inventory can be run again, and then renewing/removing the certificate will be allowed.
 - Bug fix: Discovery "Directories to Ignore" field not being used to filter results

diff --git a/RemoteFile/ImplementedStoreTypes/KDB/KDBCertificateStoreSerializer.cs b/RemoteFile/ImplementedStoreTypes/KDB/KDBCertificateStoreSerializer.cs
@@ -46,7 +46,7 @@ public Pkcs12Store DeserializeRemoteCertificateStore(byte[] storeContentBytes, s
 
             try
             {
-                remoteHandler.RunCommand(command, null, ApplicationSettings.UseSudo, null);
+                remoteHandler.RunCommand(command, null, ApplicationSettings.UseSudo, new string[] { storePassword });
 
                 byte[] storeBytes = remoteHandler.DownloadCertificateFile($"{storePath}{tempCertFile}");
                 store.Load(new MemoryStream(storeBytes), string.IsNullOrEmpty(storePassword) ? new char[0] : storePassword.ToCharArray());
@@ -84,7 +84,7 @@ public List<SerializedStoreInfo> SerializeRemoteCertificateStore(Pkcs12Store cer
                     certificateStore.Save(ms, string.IsNullOrEmpty(storePassword) ? new char[0] : storePassword.ToCharArray(), new Org.BouncyCastle.Security.SecureRandom());
                     remoteHandler.UploadCertificateFile(storePath, tempCertFile, ms.ToArray());
                 }
-                remoteHandler.RunCommand(command, null, ApplicationSettings.UseSudo, null);
+                remoteHandler.RunCommand(command, null, ApplicationSettings.UseSudo, new string[] { storePassword });
                 byte[] storeContents = remoteHandler.DownloadCertificateFile($"{storePath}{tempStoreFile}");
 
                 storeInfo.Add(new SerializedStoreInfo() { Contents = storeContents, FilePath = storePath+storeFileName });