Merge pull request #69 from Keyfactor/release-2.8

Merge 2.8.1 release to main
Keyfactor · Oct 21, 2024 · 827f6e9 · 827f6e9
2 parents 11a8936 + c721afe
commit 827f6e9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+v2.8.1
+- Fixed issue were sensitive information could be exposed at debug logging level
+
 v2.8.0
 - Added new custom field - Remove Root Certificate from Chain - to allow adding certificate entries with the root CA certificate removed from the chain.
 - Added SSH KeyboardInteractive Authentication support if Password Authentication is not enabled.

diff --git a/RemoteFile/InventoryBase.cs b/RemoteFile/InventoryBase.cs
@@ -31,8 +31,7 @@ public JobResult ProcessJob(InventoryJobConfiguration config, SubmitInventoryUpd
             logger.LogDebug($"Begin {config.Capability} for job id {config.JobId}...");
             logger.LogDebug($"Server: { config.CertificateStoreDetails.ClientMachine }");
             logger.LogDebug($"Store Path: { config.CertificateStoreDetails.StorePath }");
-            logger.LogDebug($"Store Properties: {config.CertificateStoreDetails.Properties.ToString()}");
-            logger.LogDebug($"Job Properties:");
+            logger.LogDebug($"Job Properties:"); 
             foreach (KeyValuePair<string, object> keyValue in config.JobProperties ?? new Dictionary<string,object>())
             {
                 logger.LogDebug($"    {keyValue.Key}: {keyValue.Value}");

diff --git a/RemoteFile/ManagementBase.cs b/RemoteFile/ManagementBase.cs
@@ -30,8 +30,7 @@ public JobResult ProcessJob(ManagementJobConfiguration config)
             ILogger logger = LogHandler.GetClassLogger(this.GetType());
             logger.LogDebug($"Begin {config.Capability} for job id {config.JobId}...");
             logger.LogDebug($"Server: {config.CertificateStoreDetails.ClientMachine}");
-            logger.LogDebug($"Store Path: {config.CertificateStoreDetails.StorePath}");
-            logger.LogDebug($"Store Properties: {config.CertificateStoreDetails.Properties.ToString()}");
+            logger.LogDebug($"Store Path: {config.CertificateStoreDetails.StorePath}"); 
             logger.LogDebug($"Job Properties:");
             foreach (KeyValuePair<string, object> keyValue in config.JobProperties == null ? new Dictionary<string, object>() : config.JobProperties)
             {