Feature/god advisor

[dvincent56]

Adding an information panel in religion advisor to see all epithets description for each gods.
The jupiter asset is a placeholder, should be replace in future

[Ouaz]

Some screenshots:

[crudelios]

Can you please solve the merge conflicts first? Thanks!

[dvincent56]

Update color for readability

[Areldir]

Perhaps change the white font in the last image for the one used in the titles in the second image. The more pixelated white font in the last image is a bit visually jarring compared to the smoother font - which is used more commonly across the game's UI.

[Ouaz]

Perhaps change the white font in the last image for the one used in the titles in the second image. The more pixelated white font in the last image is a bit visually jarring

The normal white font is too big and the 3 epithet descriptions do not fit in the box. :(

This tiny font trick is used in C3, when there's not enough space, e.g.:

[Areldir]

I have just added an asset to replace the AI generated portrait/button of Zeus (Commit: d5cdab0 - asset ID "Pantheon_Epithet_Button_01"), as it is not fitting for the Pantheon and is also the source of some controversy due to AI being used in its creation.

Please change over to the new image and remove the AI generated one. The button can be created from the image using the same method as the Colosseum games buttons, with the borders and vignette drawn from the code.

[dvincent56]

I think it's good right now

[crudelios]

Well, it has merge conflicts now. Can you please fix them?

[dvincent56]

Done

[crudelios]

It has merge conflicts again 😭

[dvincent56]

Conflicts resolved again !

[crudelios]

I had a look at the game, and I'm not sure about this one.

This is a help panel integrated in the advisors panel. I don't think that makes much sense. All the advisor windows provide some specific city info or allow you to change stuff, but this window is just static game information.
To exit, you must click the little arrow at the bottom, which is hard to see. You also can't change advisors while you don't click the arrow. I think it would be better to keep a button on the same spot where you pressed to get to the Epiteph info window anyway.
Also, it should be Gods' Epitephs
The tooltip for the Pantheon still says "Jupiter Epiteph", that needs changing.

[Ouaz]

but this window is just static game information.

Yes, it allows to check all god's epithets without the need of opening the manual each time (I think nobody knows them by heart ^^).
It's more convenient to have these infos available directly in-game without the need of alt-tabbing, imo.

We put it in the Religion advisor, like the advisor informs the governor about what will be granted by gods if a Great Temple and its epithet is dedicated to them.

You also can't change advisors while you don't click the arrow.

That's the common behavior on advisor panels having a sub-panel ("show Rome prices" on Trade Advisor, "Hold Games" on Entertainement Advisor, "Hold new festival" on Religion Advisor, etc.)

To exit, you must click the little arrow at the bottom, I think it would be better to keep a button on the same spot where you pressed to get to the Epiteph info window anyway.

Hmmm... Exit button on the top right corner would look awkward (as all exit buttons are on the lower right corner).
To make the exit more noticeable, what about using the "Right-click to Exit" string (<group id="13"><string id="1">), used for example in the "Show Rome Prices" subpanel?

[crudelios]

We put it in the Religion advisor, like the advisor informs the governor about what will be granted by gods if a Great Temple and its epithet is dedicated to them.

Fine by me. A bit unrelated but the smaller font may be avoided by using rich text and a scrollbar instead of regular text. However there's no support for centered titles using rich text (yet).

That's the common behavior on advisor panels having a sub-panel ("show Rome prices" on Trade Advisor, "Hold Games" on Entertainement Advisor, "Hold new festival" on Religion Advisor, etc.)

It's true, but those windows are smaller or darken the background, ie it's clear they are sub windows.

In this case that doesn't happen, as the window is exactly the same size, so it seems to be an alternative display to the religion advisor.

It's like the original housing advisor, it was also a secondary panel but it allowed moving between advisors. Only later did we add a proper tab for it.

Anyway, maybe darkening the entire background would do the trick!

Oh and also I'd rather have the button than the "right click to exit" text.

[Ouaz]

A bit unrelated but the smaller font may be avoided by using rich text and a scrollbar instead of regular text.

Problem with the scroll bar is epithets are not a continuous text, and it displayed epithets only one by one, while scrolling the bar (which was very awkward).
Hence the no-scroll-bar, the giant panel to fit all epithets in one box (needing the smaller font size though). 💆

[crudelios]

A bit unrelated but the smaller font may be avoided by using rich text and a scrollbar instead of regular text.

Problem with the scroll bar is epithets are not a continuous text, and it displayed epithets only one by one, while scrolling the bar (which was very awkward). Hence the no-scroll-bar, the giant panel to fit all epithets in one box (needing the smaller font size though). 💆

Yeah we'd be able to make it continuous if I changed the way rich text works.

Maybe something to consider for the future...

[crudelios]

I'm going to have a go at adding a @H option to rich text so it has headings, that way we can easily add the scrollbars.

I don't that will take too long.

This PR can stay on hold for that.

[dvincent56]

Yes I need to revamp this one @Ouaz sent me the update I need to do

[crudelios]

I've now added headings to the rich text.

By using @H you'll add a heading, then @L or @P closes the heading.

They look basically like the heading in the images here, with a bit more spacing between the heading and the next line.

[crudelios]

@dvincent56 @Ouaz still interested in adding this? I certainly am!

Rich text now supports headings so scrollbars should be easy to add.

[crudelios]

When I have the time I'll have a look at this myself so I can add it.

[Ouaz]

When I have the time

Haha, story of our lifes.

I barely have the time to follow Augustus progress since months -just the commit history-, thinking now and then "ah, I should resume to check what are the plans, maybe they're planning 5.0, omg french translation is stale, and there's also the Augustus manual to complete with A LOT of things", but geez, no time, never.