Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that all symlinks point to something existing within the problem package #261

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Check that all symlinks point to something existing within the problem package #261

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b9522f
Check that all symlinks point to something existing within the proble…
gkreitz May 24, 2024
7e8b7e3
Forbid all absolute symlinks
gkreitz May 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions problemtools/verifyproblem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1851,6 +1851,8 @@ def check(self, args: argparse.Namespace) -> tuple[int, int]:
if not re.match('^[a-z0-9]+$', self.shortname):
self.error(f"Invalid shortname '{self.shortname}' (must be [a-z0-9]+)")

self._check_symlinks()

run.limit.check_limit_capabilities(self)

for part in args.parts:
Expand All @@ -1861,6 +1863,30 @@ def check(self, args: argparse.Namespace) -> tuple[int, int]:
pass
return ProblemAspect.errors, ProblemAspect.warnings

def _check_symlinks(self):
"""Check that all symlinks point to something existing within the problem package"""
probdir = os.path.realpath(self.probdir)
for root, dirs, files in os.walk(probdir):
for file in dirs + files:
filename = os.path.join(root, file)
if os.path.islink(filename):
target = os.path.realpath(filename)
# relfile is the filename of the symlink, relative to the problem root (only used for nicer error messages)
relfile = os.path.relpath(filename, self.probdir)
# reltarget is what the symlink points to (absolute, or relative to where the symlink is)
reltarget = os.readlink(filename)
if not os.path.exists(target):
self.error(
f"Symlink {relfile} links to {reltarget} which does not exist"
)
if os.path.commonpath([probdir, target]) != probdir:
self.error(
f"Symlink {relfile} links to {reltarget} which is outside of problem package"
)
if os.path.isabs(reltarget):
self.error(
f"Symlink {relfile} links to {reltarget} which is an absolute path. Symlinks must be relative."
)

def re_argument(s: str) -> Pattern[str]:
try:
Expand Down