Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NRM submodel #86

Open
artgoldberg opened this issue Apr 15, 2020 · 1 comment
Open

Improve NRM submodel #86

artgoldberg opened this issue Apr 15, 2020 · 1 comment
Assignees

Comments

@artgoldberg
Copy link
Contributor

artgoldberg commented Apr 15, 2020

  1. remove reaction_index from self.dependencies[reaction_index] and eliminate the if at line 207
  2. discuss how to choose between SSA (the Direct Method) and NRM in a model
  3. add logging to the NRM submodel
  4. consider this NRM submodel optimization: compute dependencies on species shared with continuous submodels dynamically; no dependency exists if the slope has been 0 since the last reaction was executed. (don't need to look further back, because if the slope was non-0 before the previous reaction, then the propensity would have been calculated then)
@artgoldberg
Copy link
Contributor Author

artgoldberg commented Apr 17, 2020

Did 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant