Add optional property labelAfter to set label after drop operation #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KarimMokhtar can we merge this PR? |
Unfortunately, there are required changes that have not been made yet. |
|
pretty please! the "upload another?" text is not matching when the actual submit only happens later and the user has to full out other form fields |
|
@KarimMokhtar what are the requirements needed to finish and merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introducing a label to be shown after the drop is completed. Current solution always says "File is uploaded", but in my use case the file should not be uploaded on drop, but rather at a click on a separate button. Then the default text is confusing for the user, as it seems that the upload is already done at that point.
Key Changes
Check List