Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify render preview #581

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

longxiaofei
Copy link
Contributor

@longxiaofei longxiaofei commented Jun 20, 2024

Optimize preview rendering process.

Rendering previews blocks the main thread, while saving functionality and app initialization rely on main thread resources. When the Jupyter server needs to communicate over the public internet (such as with Kaggle), rendering the preview app, which requires downloading a 9MB HTML file, can slow down other functions.

@longxiaofei longxiaofei merged commit faaa969 into Kanaries:main Jun 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant