Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add global param max_data_length #550

Merged
merged 2 commits into from
May 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pygwalker/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from pygwalker.services.global_var import GlobalVarManager
from pygwalker.services.kaggle import show_tips_user_kaggle as __show_tips_user_kaggle

__version__ = "0.4.8.3"
__version__ = "0.4.8.4"
__hash__ = __rand_str()

from pygwalker.api.jupyter import walk, render, table
Expand Down
10 changes: 4 additions & 6 deletions pygwalker/api/pygwalker.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@
from pygwalker.errors import DataCountLimitError
from pygwalker import __version__

RESPONSE_MAX_DATA_LENGTH = 1 * 1000 * 1000


class PygWalker:
"""PygWalker"""
Expand Down Expand Up @@ -385,15 +383,15 @@ def upload_spec_to_cloud(data: Dict[str, Any]):
def _get_datas(data: Dict[str, Any]):
sql = data["sql"]
datas = self.data_parser.get_datas_by_sql(sql)
if len(datas) > RESPONSE_MAX_DATA_LENGTH:
if len(datas) > GlobalVarManager.max_data_length:
raise DataCountLimitError()
return {
"datas": datas
}

def _get_datas_by_payload(data: Dict[str, Any]):
datas = self.data_parser.get_datas_by_payload(data["payload"])
if len(datas) > RESPONSE_MAX_DATA_LENGTH:
if len(datas) > GlobalVarManager.max_data_length:
raise DataCountLimitError()
return {
"datas": datas
Expand All @@ -402,7 +400,7 @@ def _get_datas_by_payload(data: Dict[str, Any]):
def _batch_get_datas_by_sql(data: Dict[str, Any]):
result = self.data_parser.batch_get_datas_by_sql(data["queryList"])
for datas in result:
if len(datas) > RESPONSE_MAX_DATA_LENGTH:
if len(datas) > GlobalVarManager.max_data_length:
raise DataCountLimitError()
return {
"datas": result
Expand All @@ -411,7 +409,7 @@ def _batch_get_datas_by_sql(data: Dict[str, Any]):
def _batch_get_datas_by_payload(data: Dict[str, Any]):
result = self.data_parser.batch_get_datas_by_payload(data["queryList"])
for datas in result:
if len(datas) > RESPONSE_MAX_DATA_LENGTH:
if len(datas) > GlobalVarManager.max_data_length:
raise DataCountLimitError()
return {
"datas": result
Expand Down
5 changes: 5 additions & 0 deletions pygwalker/services/global_var.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ class GlobalVarManager:
kanaries_api_host = "https://api.kanaries.net"
kanaries_main_host = "https://kanaries.net"
last_exported_dataframe = None
max_data_length = 1000 * 1000

@classmethod
def set_env(cls, env: Literal['Jupyter', 'Streamlit']):
Expand Down Expand Up @@ -42,3 +43,7 @@ def set_privacy(cls, privacy: Literal['offline', 'update-only', 'events']):
@classmethod
def set_last_exported_dataframe(cls, df: DataFrame):
cls.last_exported_dataframe = df

@classmethod
def set_max_data_length(cls, length: int):
cls.max_data_length = length
51 changes: 0 additions & 51 deletions tests/offline.ipynb

This file was deleted.

38 changes: 26 additions & 12 deletions tests/stress-test-polars.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,30 @@
"tags": []
},
"outputs": [],
"source": [
"import pygwalker.services.config as pyg_conf\n",
"\n",
"pyg_conf.set_config({'privacy': 'offline'})"
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "e1a103bc",
"metadata": {},
"outputs": [],
"source": [
"!pygwalker config --list"
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "b944c557-ec0d-4afb-afcb-c5fb2376b25e",
"metadata": {
"tags": []
},
"outputs": [],
"source": [
"import polars as pl\n",
"df = pl.scan_csv('./bike_sharing_dc.csv', try_parse_dates = True)\n",
Expand All @@ -37,23 +61,13 @@
{
"cell_type": "code",
"execution_count": null,
"id": "b944c557-ec0d-4afb-afcb-c5fb2376b25e",
"metadata": {
"tags": []
},
"id": "527bfe29-c8fd-4051-863f-d1f63e0de4c3",
"metadata": {},
"outputs": [],
"source": [
"import pygwalker as pyg\n",
"pyg.walk(df)"
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "527bfe29-c8fd-4051-863f-d1f63e0de4c3",
"metadata": {},
"outputs": [],
"source": []
}
],
"metadata": {
Expand Down
Loading