feat(shm): add graph compression interface #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| We offer both sequential and parallel interfaces for compressing a graph stored in CSR format. While this method is the simplest to use, it is only practical if the input graph can fit in memory without compression, making it only useful in specific situations. | ||
|
|
||
| ```cpp | ||
| #include <kaminpar-shm/graphutils/compressed_graph_builder.h> |
There was a problem hiding this comment.
Should we move the declarations which users are expected to use to a different header, similar to kaminpar-shm/kaminpar.h? E.g., kaminpar-shm/terapart.h.
There was a problem hiding this comment.
I’ve moved the declaration to kaminpar-shm/kaminpar.h.. Let me know if that looks good to you.
There was a problem hiding this comment.
Looks good, one issue: could you remove the includes in kaminpar.h to other kaminpar-*/ files (otherwise, you would still need additional headers installed to use the library)? e.g. through pimpl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.