better resize implementation

KRM7 · Mar 15, 2024 · 87a1bcd · 87a1bcd
1 parent 711dec0
commit 87a1bcd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/benchmark/small_vector.cpp b/benchmark/small_vector.cpp
@@ -119,7 +119,7 @@ void benchmark_resize(benchmark::State& state)
 
     for (auto _ : state)
     {
-        vec.resize(size - 1);
+        vec.resize(0);
         benchmark::DoNotOptimize(vec);
 
         vec.resize(size);

diff --git a/src/small_vector.hpp b/src/small_vector.hpp
@@ -978,12 +978,12 @@ class small_vector
     template<typename... Args>
     constexpr void resize_impl(size_type count, Args&&... args)
     {
-        if (count < size())
+        if (count <= size())
         {
             detail::destroy_range(alloc_, first_ + count, last_);
             last_ = first_ + count;
         }
-        else if (count > size())
+        else
         {
             reserve(count);
             detail::construct_range(alloc_, last_, first_ + count, std::forward<Args>(args)...);