fix : fix CI discord notification error

KGU6 · Sep 26, 2024 · 56973eb · 56973eb
1 parent d129612
commit 56973eb
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/.github/workflows/main-deploy.yml b/.github/workflows/main-deploy.yml
@@ -74,13 +74,15 @@ jobs:
 
   result:
     name: Send notification
+    needs: [build, deploy]
     runs-on: ubuntu-latest
     steps:
-      - name: Send Discord notification
-        if: ${{ job.status }}
+      - name: Send Discord notification on success
+        if: ${{ needs.build.result == 'success' && needs.deploy.result == 'success' }}
         run: |
-          if [ "${{ job.status }}" == "success" ]; then
-            curl -X POST -H "Content-Type: application/json" -d '{"content": "✅ : Deployment to AWS ECS was successful!"}' ${{ secrets.DISCORD_WEBHOOK_URL }}
-          else
-            curl -X POST -H "Content-Type: application/json" -d '{"content": "❌ : Deployment to AWS ECS failed!"}' ${{ secrets.DISCORD_WEBHOOK_URL }}
-          fi
+          curl -X POST -H "Content-Type: application/json" -d '{"content": "✅ : Deployment to AWS ECS was successful!"}' ${{ secrets.DISCORD_WEBHOOK_URL }}
+
+      - name: Send Discord notification on failure
+        if: ${{ needs.build.result != 'success' || needs.deploy.result != 'success' }}
+        run: |
+          curl -X POST -H "Content-Type: application/json" -d '{"content": "❌ : Deployment to AWS ECS failed!"}' ${{ secrets.DISCORD_WEBHOOK_URL }}