-
-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupyter messaging updates/correctness #1138
Jupyter messaging updates/correctness #1138
Conversation
(Necessary for any future `"update_display_data"` message implementation)
236b63e
to
bcf8553
Compare
Bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly necessary for this PR, but we should start using jupyter_kernel_test
in the tests: https://github.com/jupyter/jupyter_kernel_test
8b56a0c
to
f63ccfb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1138 +/- ##
==========================================
- Coverage 10.51% 10.48% -0.03%
==========================================
Files 14 14
Lines 818 820 +2
==========================================
Hits 86 86
- Misses 732 734 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
pkgversion
in"kernel_info_request"
to report the IJulia version"kernel_info_request"
sent on both the shell/requests channel AND the control channel. (The latter is not described as possible according to the docs.){ 'status': 'ok' }
transient
metadata field was added in protocol version 5.1. Without the ability to add transient metadata,"update_display_data"
messages can't be used to update/redisplay existing outputs (while participating in/with the rest of the IJulia display machinery). Related PR Function to publish raw/encoded display data #946 is more extensive and stalled; this is the minimum necessary change to support this.Fixes #953
Fixes #1000
Reference: https://jupyter-client.readthedocs.io/en/latest/messaging.html