Fix overlaps on polygons that only interact at vertices
#238
+79
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the test case I added
asinghvi17
changed the title
overlaps on polygons that only interact at vertices
asinghvi17
commented
Feb 25, 2025
Comment on lines
+88
to
+91
| # # Convert features to geometries | ||
| overlaps(::GI.FeatureTrait, g1, ::Any, g2) = overlaps(GI.geometry(g1), g2) | ||
| overlaps(::Any, g1, t2::GI.FeatureTrait, g2) = overlaps(g1, GI.geometry(g2)) | ||
| overlaps(::FeatureTrait, g1, ::FeatureTrait, g2) = overlaps(GI.geometry(g1), GI.geometry(g2)) |
There was a problem hiding this comment.
This is the only thing that CI doesn't cover. We could remove it - but TBH it should be fine I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overlaps failed for a polygon like this (see the changes to
testfor the polygons), where the polygons overlap but only intersect at vertices (so every line-line intersection is a hinge intersection)this PR attempts to move the implementation to the geom_geom_processor interface. Still fails for lines where one line covers another. Maybe I need some adjustments to the allows/requires?
cc @skygering