Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for Julia 1.11 #100

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Fix tests for Julia 1.11 #100

merged 2 commits into from
Dec 4, 2024

Conversation

nhz2
Copy link
Contributor

@nhz2 nhz2 commented Dec 4, 2024

An exception changed from a MethodError to a BoundsError in Julia 1.11.

An exception changed from a `MethodError` to a `BoundsError` in Julia 1.11.
Copy link
Collaborator

@alyst alyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!
Could you please change it to the suggestion (I'm not 100% sure it will work out-of-the-box, but the idea is too keep the test specifically checking for the incompatible value type assignment)

test/DictoVec.jl Outdated Show resolved Hide resolved
Co-authored-by: Alexey Stukalov <alyst@users.noreply.github.com>
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.46%. Comparing base (aa8bc3f) to head (3a56081).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   89.61%   89.46%   -0.15%     
==========================================
  Files          14       14              
  Lines         693      693              
==========================================
- Hits          621      620       -1     
- Misses         72       73       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nhz2 nhz2 requested a review from alyst December 4, 2024 23:44
Copy link
Collaborator

@alyst alyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alyst alyst merged commit 2485c65 into JuliaData:main Dec 4, 2024
16 of 17 checks passed
@nhz2 nhz2 deleted the patch-1 branch December 4, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants