Update TileConfig parameters to use input_ext and output_ext #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `TileConfig` class and CLI script to use separate `input_ext` and `output_ext` parameters. * **TileConfig Class:** - Replace `ext` parameter with `input_ext` and `output_ext` parameters. - Modify methods to use `input_ext` for reading images and `output_ext` for saving tiled images. - Adjust `_save_tile_image` method to use `output_ext` for saving images. - Set `output_ext` to `None` by default, and if `None`, use `input_ext`. * **CLI Script:** - Replace `--ext` argument with `--input_ext` and `--output_ext` arguments. - Update `TileConfig` instantiation to use `input_ext` and `output_ext` arguments. * **README.md:** - Update usage examples to reflect changes in `TileConfig` class and CLI script. - Provide examples for using `input_ext` and `output_ext` parameters. * **Tests:** - Update test configuration to use `input_ext` and `output_ext` parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
TileConfigclass and CLI script to use separateinput_extandoutput_extparameters.TileConfig Class:
extparameter withinput_extandoutput_extparameters.input_extfor reading images andoutput_extfor saving tiled images._save_tile_imagemethod to useoutput_extfor saving images.output_exttoNoneby default, and ifNone, useinput_ext.CLI Script:
--extargument with--input_extand--output_extarguments.TileConfiginstantiation to useinput_extandoutput_extarguments.README.md:
TileConfigclass and CLI script.input_extandoutput_extparameters.Tests:
input_extandoutput_extparameters.